fix settings syntax error in settings#45
Merged
yonaries merged 1 commit intothe-ora:mainfrom Sep 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a syntax error in the SpacesSettingsView by correcting malformed VStack and Picker code structure that was preventing compilation.
- Removed orphaned closing parenthesis and misplaced ForEach block
- Added missing
.foregroundStyle(.secondary)modifier to complete the Text styling - Restructured the Picker implementation to properly contain the search engine options
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
yonaries
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor UI improvement to the
SpacesSettingsViewin the settings module. The change refines the appearance of the "Space-Specific Defaults" section by updating the styling of the explanatory text..foregroundStyle(.secondary)for improved readability and visual distinction, replacing the previous multilineTextand removing the associatedForEachblock for search engines. (ora/Modules/Settings/Sections/SpacesSettingsView.swift)