Skip to content

feat(toolbar): add slide transition to toolbar on toggle#77

Merged
yonaries merged 1 commit intothe-ora:mainfrom
omaredu:enhancement/add-transition-on-toolbar-toggle
Sep 11, 2025
Merged

feat(toolbar): add slide transition to toolbar on toggle#77
yonaries merged 1 commit intothe-ora:mainfrom
omaredu:enhancement/add-transition-on-toolbar-toggle

Conversation

@omaredu
Copy link
Copy Markdown
Contributor

@omaredu omaredu commented Sep 10, 2025

Description

I just added a tiny transition when the toolbar is toggled. Now it feels smoother.

Screen.Recording.2025-09-10.at.11.05.58.a.m.mov

Copilot AI review requested due to automatic review settings September 10, 2025 17:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds smooth slide transitions to the toolbar toggle functionality in the Ora app. The changes implement easeInOut animations when showing/hiding the toolbar and add asymmetric push transitions to both the URLBar and SidebarView components.

  • Added withAnimation wrapper to toolbar toggle buttons with 0.2-second easeInOut duration
  • Implemented asymmetric push transitions for URLBar (top insertion, bottom removal)
  • Applied similar asymmetric transitions to SidebarView with additional opacity effects

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
ora/oraApp.swift Added animation wrapper to toolbar toggle actions and reorganized imports
ora/Modules/Sidebar/SidebarView.swift Added asymmetric push transitions with opacity effects
ora/Modules/Browser/BrowserView.swift Added asymmetric push transitions to URLBar component

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@yonaries yonaries merged commit 0a39d46 into the-ora:main Sep 11, 2025
2 checks passed
@omaredu omaredu deleted the enhancement/add-transition-on-toolbar-toggle branch September 11, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants