feat: EmbeddingClient with Ollama and OpenAI providers#25
Merged
jordanpartridge merged 3 commits intomainfrom Apr 6, 2026
Merged
feat: EmbeddingClient with Ollama and OpenAI providers#25jordanpartridge merged 3 commits intomainfrom
jordanpartridge merged 3 commits intomainfrom
Conversation
Introduces a provider-agnostic embedding layer so consumers don't need to roll their own HTTP clients for generating vector embeddings. - EmbeddingClient contract: embed() and embedBatch() - OllamaEmbeddings: Saloon connector calling POST /api/embed - OpenAiEmbeddings: Saloon connector calling POST /v1/embeddings with Bearer auth (works with any OpenAI-compatible API) - NullEmbeddings: stub for testing / disabled embedding - Config-driven provider selection via config/vector.php - VectorServiceProvider binds the correct implementation Closes #24
Cover Qdrant::listCollections() and ListCollectionsRequest — the only two gaps preventing the --min=100 coverage gate from passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EmbeddingClientcontract withembed()andembedBatch()OllamaEmbeddings— Saloon connector callingPOST /api/embedOpenAiEmbeddings— Saloon connector callingPOST /v1/embeddingswith Bearer auth (works with any OpenAI-compatible API)NullEmbeddings— stub for testing or disabled embeddingconfig/vector.php(ollama,openai,none)VectorServiceProviderbinds the correct implementation based on configNew files
Test plan
Closes #24