helper functions and other clean-ups #1493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This needs a few minor fixups to look better. |
The .pcap files come from tcpdump tests.
This generates exactly the same filter program.
This generates exactly the same filter program, so there isn't any change to the tests.
infrastation
force-pushed
the
helper_functions
branch
from
d9be7dc to
c919e98
Compare
Member
Author
|
This revision seems right. |
Member
Author
|
I have another WIP change along the same lines, but it is not ready yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of changes deduplicates some C code in
gencode.cwithout affecting the resulting filter program.