Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the macOS app to version 4.1 and includes multiple UI text improvements, renaming of the local LLM provider, and adjustments for provider configuration and error handling. Key changes include:
- Renaming “LocalLLMProvider” to “LocalModelProvider” throughout the code and updating related initializer arguments.
- UI and content updates in SettingsView and OnboardingView (improved text, spacing, and model filtering controls).
- Version bumps and signing configuration updates in AboutView, UpdateChecker, project files, and README.
- Parameter enhancements in MistralProvider for streaming requests.
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| macOS/writing-tools/Views/Settings/SettingsView.swift | Updated text strings, provider renaming from LocalLLMProvider to LocalModelProvider, and refined alert and view behavior. |
| macOS/writing-tools/Views/Onboarding/OnboardingView.swift | UI layout improvements, adjusted spacing and text styling, and minor content rewording. |
| macOS/writing-tools/Services/UpdateChecker.swift, AboutView.swift, project files, README | Version bumps from 4.0 to 4.1 and configuration/signing updates. |
| macOS/writing-tools/Models/AI Providers/MistralProvider.swift | Added the secondsToWait parameter to streaming requests for consistency. |
| Other files | Removal or renaming of components (FloatingIcon files, LocalLLMProvider) to align with new naming conventions. |
Comments suppressed due to low confidence (4)
macOS/writing-tools/Views/Settings/SettingsView.swift:215
- The provider check has been updated to use LocalModelProvider instead of LocalLLMProvider; please ensure that all references and documentation have been consistently updated accordingly.
if LocalModelProvider.isAppleSilicon {
macOS/writing-tools.xcodeproj/project.pbxproj:327
- The code signing configuration has been updated to use 'Developer ID Application' with a manual signing style; ensure that this change is intentional and that your release process and documentation reflect the new signing setup.
"CODE_SIGN_STYLE" = Manual;
macOS/writing-tools/Views/Settings/SettingsView.swift:261
- The initializer argument for LocalLLMSettingsView has changed from 'evaluator' to 'provider'; verify that the view’s initializer signature and all related usages correctly reflect the new naming convention.
LocalLLMSettingsView(provider: appState.localLLMProvider)
macOS/writing-tools/Views/Onboarding/OnboardingView.swift:101
- [nitpick] The addition of .scaledToFit() to the onboarding image ensures proper scaling; please double-check that this behavior matches the intended design across different screen sizes.
.scaledToFit()
theJayTea
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.