Skip to content

macOS v4.1#190

Merged
theJayTea merged 2 commits intomainfrom
macOS-v4_4
May 15, 2025
Merged

macOS v4.1#190
theJayTea merged 2 commits intomainfrom
macOS-v4_4

Conversation

@Aryamirsepasi
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the macOS app to version 4.1 and includes multiple UI text improvements, renaming of the local LLM provider, and adjustments for provider configuration and error handling. Key changes include:

  • Renaming “LocalLLMProvider” to “LocalModelProvider” throughout the code and updating related initializer arguments.
  • UI and content updates in SettingsView and OnboardingView (improved text, spacing, and model filtering controls).
  • Version bumps and signing configuration updates in AboutView, UpdateChecker, project files, and README.
  • Parameter enhancements in MistralProvider for streaming requests.

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
macOS/writing-tools/Views/Settings/SettingsView.swift Updated text strings, provider renaming from LocalLLMProvider to LocalModelProvider, and refined alert and view behavior.
macOS/writing-tools/Views/Onboarding/OnboardingView.swift UI layout improvements, adjusted spacing and text styling, and minor content rewording.
macOS/writing-tools/Services/UpdateChecker.swift, AboutView.swift, project files, README Version bumps from 4.0 to 4.1 and configuration/signing updates.
macOS/writing-tools/Models/AI Providers/MistralProvider.swift Added the secondsToWait parameter to streaming requests for consistency.
Other files Removal or renaming of components (FloatingIcon files, LocalLLMProvider) to align with new naming conventions.
Comments suppressed due to low confidence (4)

macOS/writing-tools/Views/Settings/SettingsView.swift:215

  • The provider check has been updated to use LocalModelProvider instead of LocalLLMProvider; please ensure that all references and documentation have been consistently updated accordingly.
if LocalModelProvider.isAppleSilicon {

macOS/writing-tools.xcodeproj/project.pbxproj:327

  • The code signing configuration has been updated to use 'Developer ID Application' with a manual signing style; ensure that this change is intentional and that your release process and documentation reflect the new signing setup.
"CODE_SIGN_STYLE" = Manual;

macOS/writing-tools/Views/Settings/SettingsView.swift:261

  • The initializer argument for LocalLLMSettingsView has changed from 'evaluator' to 'provider'; verify that the view’s initializer signature and all related usages correctly reflect the new naming convention.
LocalLLMSettingsView(provider: appState.localLLMProvider)

macOS/writing-tools/Views/Onboarding/OnboardingView.swift:101

  • [nitpick] The addition of .scaledToFit() to the onboarding image ensures proper scaling; please double-check that this behavior matches the intended design across different screen sizes.
.scaledToFit()

@theJayTea theJayTea merged commit 55e201a into main May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants