Can external libaries be used? #164
Closed
CapnKernel
started this conversation in
Ideas
Replies: 1 comment 1 reply
|
I won't outright reject the idea, but it would take an extremely strong justification to include any runtime dependencies into KiCanvas. I would not recommend starting work on a PR that depends on a new runtime dependency without thoroughly discussing it first. Extremely strong justification essentially amounts to "KiCanvas would not be usable without it". An example is earcut.js, which is (a) essential, (b) tiny, (c) vendored into |
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Is this still true?
I'm considering adding a feature, but the code would work much better with the aid of an external dependency (sortablejs). Would you reject a PR for a feature that used sortablejs?
All reactions