refactor: create llm package with Ollama implementation#153
Merged
theantichris merged 4 commits intomainfrom Dec 27, 2025
Merged
refactor: create llm package with Ollama implementation#153theantichris merged 4 commits intomainfrom
theantichris merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the codebase by extracting Ollama-specific LLM functionality into a dedicated internal/llm package. The changes improve code organization by separating concerns and making the LLM client logic reusable.
Key changes:
- Created new
internal/llmpackage with Ollama chat implementation - Moved chat-related types (
ChatRequest,ChatResponse,ChatMessage) from main to the llm package - Removed
getChatResponsefunction from main and replaced withllm.Chatfunction
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/llm/ollama.go | New file containing Ollama chat implementation with exported types and Chat function |
| main.go | Removed chat-related types and getChatResponse function; now uses llm.Chat for communication |
| main_test.go | Updated to use llm.ChatMessage type; removed TestGetChatResponse test function |
| .harper-dictionary.txt | Added ChatResponse to dictionary |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.