Fix compatibility with django-polymorphic 4.6#279
Open
didacta wants to merge 1 commit intotheatlantic:masterfrom
Open
Fix compatibility with django-polymorphic 4.6#279didacta wants to merge 1 commit intotheatlantic:masterfrom
didacta wants to merge 1 commit intotheatlantic:masterfrom
Conversation
…ic API Use model._meta.parents.keys() instead of the private method to get parent model classes. This is cleaner and more stable across Django versions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #279 +/- ##
==========================================
- Coverage 78.97% 75.40% -3.57%
==========================================
Files 20 20
Lines 2587 2586 -1
==========================================
- Hits 2043 1950 -93
- Misses 544 636 +92
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
This does not fix the problem completely for me. I needed to change another line, see 254b04d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces private
_get_inheritance_relation_fields_and_models()API withDjango's public
model._meta.parents.keys().Context
django-polymorphic 4.6 removed/changed the private method this code depended on.
See: jazzband/django-polymorphic@v4.5.1...v4.6.0
Related issue: #278