Skip to content

Conversation

@mchlnix
Copy link
Contributor

@mchlnix mchlnix commented Aug 28, 2019

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 83.048% when pulling a81f272 on mchlnix:patch-1 into 361d176 on thebjorn:master.

@thebjorn
Copy link
Owner

Thanks for the PR. Some of your edits are very linux (not all shells start their command lines $) or even Debian/Ubuntu centric (apt-get install...). pydeps runs very well on Windows (the only platform where I use it), and if I add the ubuntu/debian command to install graphviz I would probably need to add the yum/pacman/dnf/zypper/emerge commands too -- and none of those would help BSD or Windows users...

@mchlnix
Copy link
Contributor Author

mchlnix commented Aug 28, 2019

I thought of that, too and I guess it is your choice how you want to go about it. You can revert some of the changes if you want. While I'm pretty linux centric, I just wanted something to denote, that this is a shell command. I guess you could also use "> " to make it a bit more platform independent. I actually don't know what a windows shell looks like. :)

Edit: And of course apt-get is pretty debian centric, but I think people who are interested in your project can probably figure out, that they have to substitute something. I meant it more as a signal to "package manager install" graphviz however you like. Debian's way just happened to be my default.

@thebjorn thebjorn merged commit 8dd5a96 into thebjorn:master Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants