Skip to content

Conversation

@jwbargsten
Copy link

  • moved logging for cli in separate module
  • removed global start color variable

should fix #59

* moved logging for cli in separate module
* removed global start color variable
@coveralls
Copy link

coveralls commented Jun 18, 2020

Coverage Status

Coverage decreased (-2.6%) to 77.082% when pulling 523e801 on jwbargsten:issues/59_programmatic-use into e56aac1 on thebjorn:master.

@jwbargsten jwbargsten force-pushed the issues/59_programmatic-use branch from cad42f1 to 4cae2bc Compare June 18, 2020 15:35
@jwbargsten jwbargsten force-pushed the issues/59_programmatic-use branch from 4cae2bc to 523e801 Compare June 18, 2020 15:37
@thebjorn
Copy link
Owner

Hi Joachim, and thank you for your interest in pydeps. Please make separate PRs for the distinct topics you're covering (logging, start_color, py2 support). The start_color fix looks interesting, the logging fix seems to skip -vvv and -vvvv support, and py2 is still a viable platform for us so removing support is a non-starter.

@jwbargsten
Copy link
Author

Sounds good. Let's tackle this! I'll have a look later today

@jwbargsten
Copy link
Author

I'll then close this PR and create new ones.

@jwbargsten jwbargsten closed this Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Programmatic use

3 participants