Fix invalid index.d.ts #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes incorrect module augmentation declaration, fixes exporting an undefined name.
Jessidhia
commented
May 18, 2018
| onChange?: (inView: boolean) => void | ||
| } | ||
|
|
||
| export default Component |
Author
There was a problem hiding this comment.
This was exporting a value that doesn't exist, making using the component a type error everywhere.
| import { RenderProps } from 'react-intersection-observer' | ||
| import React = require('react') | ||
|
|
||
| declare module 'react-intersection-observer' { |
Author
There was a problem hiding this comment.
This is already the declaration for a module named react-intersection-observer, there's no need to explicitly declare it.
Also, because there was an import / export outside the declare, this wasn't actually declaring the module but... self-augmenting?
Owner
|
Looks good! I'm personally using Flow - any ideas for how the project could validate the .d.ts file as part of the build process? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect module augmentation declaration, fixes exporting an undefined name.
The bulk of the change is just a reindent so looking at https://github.com/thebuilder/react-intersection-observer/pull/72/files?w=1 will be easier.