Simplify the API #88
Merged
Simplify the API #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes `render`, and changes `children` to only accept a function
Closed
johnrackles
pushed a commit
to johnrackles/react-intersection-observer
that referenced
this pull request
Feb 19, 2020
* refactor: rewrite the component This removes `render`, and changes `children` to only accept a function * refactor: accept plain children with deprecation warning * test: test the deprecated methods * test: reset NODE_ENV * fix: spread props to the plain child * style: apply prettier * refactor: log the DOM node in deprecations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
render, and changeschildrento only accept a function.It'll still accept
renderbut, throws a warning.