This repository was archived by the owner on Aug 23, 2022. It is now read-only.
Choose the proper video source when downloading or watching videos #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't be sure if the replay is still being generated or was deleted. You can observe this by waiting on someone's live to go offline, then you immediately grab the video ID and try looking it up. Both `videosource` and `hlsvideosource` properties are going to be empty until the replay is fully generated.
It's guaranteed to _always_ return a M3U8 URL now. Source: Just trust me dawg.
Hides the status message when opening settings or going home
If the user clicked to watch a replay just after a live stream ended, there will be no video sources available, because LiveMe would be generating the replay. The replay could also be deleted in the meantime as well, so we warn the user with a helpful message.
I accidentally a word
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #84.
I've added more details in the commits' description. But basically it should never fail to download or watch a video/stream/replay (unless the video is in fact unavailable, obviously).
I've also added some helpful messages. This one is while searching for a video id that might had gone offline recently:
This next one is exactly like the previous one, but is added to the video player window. It's triggered if the user clicked to watch a replay/livestream right after the streamer went offline. It's unlikely to happen, but a helpful message won't hurt anyway:
Let me know what you think!