Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the Docker image matrix by introducing Debian trixie variants and adding Node.js 26.x images, while updating the Dockerfile generator blueprint and CI workflow to build/test the new variants.
Changes:
- Add Debian
trixie-slim-based Dockerfiles for Node20/22/24/26(standalone + apache, build + non-build). - Add Node
26.xBullseye variants and update CI matrix to build/test the new variants. - Update the Dockerfile blueprint to (a) use
usermodinstead ofadduserfor sudo group membership and (b) install Corepack for Node>= 26.
Reviewed changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/Dockerfile.blueprint | Template updates for sudo user creation and Corepack installation for Node >= 26. |
| README.md | Document new Debian Trixie / Node 26 image tags. |
| orbit.yml | Generate additional Dockerfiles (Node 26 + Trixie variants). |
| .github/workflows/workflow.yml | Expand CI matrix to build/test Node 26 and Trixie variants. |
| Dockerfile.26-trixie-build | New generated Dockerfile for Node 26 standalone build on Debian Trixie. |
| Dockerfile.26-trixie | New generated Dockerfile for Node 26 standalone on Debian Trixie. |
| Dockerfile.26-bullseye-build | New generated Dockerfile for Node 26 standalone build on Debian Bullseye. |
| Dockerfile.26-bullseye | New generated Dockerfile for Node 26 standalone on Debian Bullseye. |
| Dockerfile.26-apache-trixie-build | New generated Dockerfile for Node 26 apache build on Debian Trixie. |
| Dockerfile.26-apache-trixie | New generated Dockerfile for Node 26 apache on Debian Trixie. |
| Dockerfile.26-apache-bullseye-build | New generated Dockerfile for Node 26 apache build on Debian Bullseye. |
| Dockerfile.26-apache-bullseye | New generated Dockerfile for Node 26 apache on Debian Bullseye. |
| Dockerfile.24-trixie-build | New generated Dockerfile for Node 24 standalone build on Debian Trixie. |
| Dockerfile.24-trixie | New generated Dockerfile for Node 24 standalone on Debian Trixie. |
| Dockerfile.24-apache-trixie-build | New generated Dockerfile for Node 24 apache build on Debian Trixie. |
| Dockerfile.24-apache-trixie | New generated Dockerfile for Node 24 apache on Debian Trixie. |
| Dockerfile.22-trixie-build | New generated Dockerfile for Node 22 standalone build on Debian Trixie. |
| Dockerfile.22-trixie | New generated Dockerfile for Node 22 standalone on Debian Trixie. |
| Dockerfile.22-apache-trixie-build | New generated Dockerfile for Node 22 apache build on Debian Trixie. |
| Dockerfile.22-apache-trixie | New generated Dockerfile for Node 22 apache on Debian Trixie. |
| Dockerfile.20-trixie-build | New generated Dockerfile for Node 20 standalone build on Debian Trixie. |
| Dockerfile.20-trixie | New generated Dockerfile for Node 20 standalone on Debian Trixie. |
| Dockerfile.20-apache-trixie-build | New generated Dockerfile for Node 20 apache build on Debian Trixie. |
| Dockerfile.20-apache-trixie | New generated Dockerfile for Node 20 apache on Debian Trixie. |
| Dockerfile.24-bullseye-build | Update sudo group addition to use usermod. |
| Dockerfile.24-bullseye | Update sudo group addition to use usermod. |
| Dockerfile.24-apache-bullseye-build | Update sudo group addition to use usermod. |
| Dockerfile.24-apache-bullseye | Update sudo group addition to use usermod. |
| Dockerfile.22-bullseye-build | Update sudo group addition to use usermod. |
| Dockerfile.22-bullseye | Update sudo group addition to use usermod. |
| Dockerfile.22-apache-bullseye-build | Update sudo group addition to use usermod. |
| Dockerfile.22-apache-bullseye | Update sudo group addition to use usermod. |
| Dockerfile.20-bullseye-build | Update sudo group addition to use usermod. |
| Dockerfile.20-bullseye | Update sudo group addition to use usermod. |
| Dockerfile.20-apache-bullseye-build | Update sudo group addition to use usermod. |
| Dockerfile.20-apache-bullseye | Update sudo group addition to use usermod. |
| Dockerfile.18-bullseye-build | Update sudo group addition to use usermod. |
| Dockerfile.18-bullseye | Update sudo group addition to use usermod. |
| Dockerfile.18-apache-bullseye-build | Update sudo group addition to use usermod. |
| Dockerfile.18-apache-bullseye | Update sudo group addition to use usermod. |
| Dockerfile.16-bullseye-build | Update sudo group addition to use usermod. |
| Dockerfile.16-bullseye | Update sudo group addition to use usermod. |
| Dockerfile.16-apache-bullseye-build | Update sudo group addition to use usermod. |
| Dockerfile.16-apache-bullseye | Update sudo group addition to use usermod. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
In addition to Bullseye, we now add Debian Trixie images
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to Bullseye, we now add Debian Trixie images