adding request format handling (for json) caution, this request should be merged along with splash-common's one #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d be merged along with splash-common's one
moufmouf
added a commit
to thecodingmachine/mvc.splash-common
that referenced
this pull request
Mar 15, 2016
passing to Http500HandlerInterface::server error (lnked to thecodingmachine/mvc.splash#21)
|
|
||
| $acceptType = $request->getHeader('Accept'); | ||
| if (is_array($acceptType) && count($acceptType) > 0 && strpos($acceptType[0], "json") !== false ){ | ||
| return new JsonResponse(["error" => ["message" => $exception->getMessage(), "type" => "Exception", "trace" => DEBUG ? $exception->getTraceAsString() : ""]]); |
There was a problem hiding this comment.
Est-ce que tu peux retirer la référence en dur à DEBUG et le changer par la variable de classe $debugMode?
L'idée est de ne jamais mettre de constante en dur dans nos paquets, mais à la place injecter les constantes dans les classes via Mouf (c'est plus souple)
|
Done ! |
moufmouf
added a commit
that referenced
this pull request
Mar 15, 2016
adding request format handling (for json) caution, this request should be merged along with splash-common's one
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.