Skip to content

Fix bootstrapFiles not loaded due to early constructor reflection #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix bootstrapFiles not loaded due to early constructor reflection #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/Type/Php/JsonDecodeDynamicReturnTypeExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,10 @@
*/
final class JsonDecodeDynamicReturnTypeExtension implements DynamicFunctionReturnTypeExtension
{
private FunctionReflection $nativeJsonDecodeReflection;

public function __construct(
private readonly JsonThrowOnErrorDynamicReturnTypeExtension $phpstanCheck,
ReflectionProvider $reflectionProvider,
private readonly ReflectionProvider $reflectionProvider,
) {
$this->nativeJsonDecodeReflection = $reflectionProvider->getFunction(new Name('json_decode'), null);
}

public function isFunctionSupported(FunctionReflection $functionReflection): bool
Expand All @@ -34,7 +31,9 @@ public function isFunctionSupported(FunctionReflection $functionReflection): boo

public function getTypeFromFunctionCall(FunctionReflection $functionReflection, FuncCall $functionCall, Scope $scope): Type
{
$result = $this->phpstanCheck->getTypeFromFunctionCall($this->nativeJsonDecodeReflection, $functionCall, $scope);
$nativeJsonDecodeReflection = $this->reflectionProvider->getFunction(new Name('json_decode'), null);

$result = $this->phpstanCheck->getTypeFromFunctionCall($nativeJsonDecodeReflection, $functionCall, $scope);

// if PHPStan reports null and there is a json error, then an invalid constant string was passed
if ($result->isNull()->yes() && JSON_ERROR_NONE !== json_last_error()) {
Expand Down