Conversation
oliverklee
reviewed
Mar 3, 2026
Contributor
oliverklee
left a comment
oliverklee
left a comment
There was a problem hiding this comment.
In the generator composer.json, we should also then use "phpunit/phpunit": "^12.5.14", to ensure the fixed version is used.
Collaborator
Author
|
Yup - also "update all our deps" is pulling in a new version of phpstan too, which updates phpstan's function database, which is causing other backwards-incompatible changes 😭 |
Collaborator
Author
|
Redone to only update phpunit (plus necessary dependencies, not all dependencies), and specify a new minimum in composer.json Looks like 8.6 had recent changes, so sending a new PR to re-sync those first... |
phpunit 12.5.7 has a security hole which I can't imagine actually affecting us (if an attacker has access to modify files on your dev machine, then phpunit can be tricked into executing one of those files), but no harm in using a safer version
oliverklee
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phpunit 12.5.7 has a security hole which I can't imagine actually affecting us (if an attacker has access to modify files on your dev machine, then phpunit can be tricked into executing one of those files), but no harm in using a safer version