Tree Shaking

[vltansky]

Would it be possible to structure the project to allow tree-shaking, so only the required modules are included?

For example, if I only need reversePath and normalizePath, I still end up importing 14KB gzipped. Ideally, I would like to be able to import just normalizePath without the extra overhead smth like import { normalizePath, reversePath } from 'svg-path-commander';

[thednp]

I'm still working to figure out how tree shaking works with vite builds.

I'll update you with anything I can find, meanwhile feel free to make a PR.

[thednp]

@vltansky please try this

npm install github:thednp/svg-path-commander

check if tree shaking works and let me know.

[vltansky]

Am I supposed to import this way?
import { parsePathString, reversePath } from 'svg-path-commander';
if yes, I'm getting Module '"svg-path-commander"' has no exported member 'parsePathString'. Did you mean to use 'import parsePathString from "svg-path-commander"' instead?

otherwise, it seems not to be tree shaked
that's what I'm doing:

import SVGPathCommander from 'svg-path-commander';

 const pathArray = SVGPathCommander.parsePathString(path);
 const res = SVGPathCommander.reversePath(pathArray);
 console.log(res);

[thednp]

What if we export the tools in a separate module, EG: import { parsePathString } from "svg-path-commander/util"?

[vltansky]

sounds good

[thednp]

I have it working in the latest master version, somehow, not sure is tree shaking or not, just types don't seem to work at all.

[vltansky]

managed to build util types with tsup take a look

[vltansky]

It might be even easier to use tsup for the build as well
Check out this PR: #54

Let me know if you want me to continue working on any of these drafts, or feel free to finish them yourself if you prefer.

[thednp]

Thank you for taking the time.

Your PR indeed seems to address the typescript part, but it doesn't solve the problem at hand.

I've been testing tsup myself, and I'm also moving to a tsup setup now, seems to me vite is more like an app builder more than a library builder. The problem is that we cannot set output file names with tsup and we'll have to release a major version to highlight the changing in file names.

[thednp]

@vltansky
Oh oh, disregard the above, you've done some PR I didn't see it coming.

I'm testing your PRs and I noticed the util module doesn't have d.ts

[thednp]

@vltansky

I think we nailed it. I went back to vite for bundling IIFE, the tsup version didn't work in the browser.

Please try my master version and let me know.

🙏 Thank you so much again.

[vltansky]

The master version works for me!

I’m seeing an 8.4 KB import size for parsePathString and reversePath.
It looks like parsePathString alone takes up 7 KB - does that make sense?

By the way, do we actually need the util folder with the current setup? Maybe we could re-export from index instead?

[thednp]

By the way, do we actually need the util folder with the current setup? Maybe we could re-export from index instead?

I'm not sure my friend, I don't have much time to investigate unfortunately. I try to focus my time to fixing functionality and less time to work with tooling, that's why I decided to use deno for formatting, linting, and possibly testing in the future.

Please feel free to add more commits to your fork and tag me here, I will install and test your fork it as soon as I can.

I’m seeing an 8.4 KB import size for parsePathString and reversePath

I know parsePathSttring is around 1-2Kb but reverse path needs to absolutize and normalize the patharray to do its thing, I believe this makes sense..

Curious: any idea what was the size before? Is this 8.4Kb size minimized or not minimized?

[vltansky]

its gziped, size before was 14kb so its almost half 🎉
Ok, I'll open PR soon and will let you know