-
Notifications
You must be signed in to change notification settings - Fork 1
Use last movements end as start for next #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| start_direction: Rotation2d | ||
| end: Pose2d | ||
| interior: List[Translation2d] | ||
| config: TrajectoryConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we intend on having different configs for any movement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its useful to have (e.g. we might find we want to do the second leg of the five ball slower to let it rotate sooner or we might want to have a move-shoot movement👀), I can make it have a default if your worry was the movement constructor being lengthy
|
I like it - unrelated, but while you are messing with auto stuff let's add a waypoint to the 5 ball to move the robot back to close to its starting position ready to pick up the ball just on the opposition side of the field. |
| start_direction=Rotation2d.fromDegrees(-45), | ||
| end=Pose2d(0.4, -2.5, Rotation2d.fromDegrees(30)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| start_direction=Rotation2d.fromDegrees(-45), | |
| end=Pose2d(0.4, -2.5, Rotation2d.fromDegrees(30)), | |
| start_direction=Rotation2d.fromDegrees(0), | |
| end=Pose2d(0.4, -2.5, Rotation2d.fromDegrees(0)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Faster and more direct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it go down to avoid any collisions with another robot that starts in our tarmac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it also only adds 156ms to the path
This reverts commit d512193.
Now you dont have to change the pose twice if you want to move a waypoint
Also removed four ball as if our alliance partner can't do a five ball we will.