Skip to content

Conversation

@OliverW10
Copy link
Member

Now you dont have to change the pose twice if you want to move a waypoint

Also removed four ball as if our alliance partner can't do a five ball we will.

start_direction: Rotation2d
end: Pose2d
interior: List[Translation2d]
config: TrajectoryConfig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we intend on having different configs for any movement?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its useful to have (e.g. we might find we want to do the second leg of the five ball slower to let it rotate sooner or we might want to have a move-shoot movement👀), I can make it have a default if your worry was the movement constructor being lengthy

@james-ward
Copy link
Contributor

I like it - unrelated, but while you are messing with auto stuff let's add a waypoint to the 5 ball to move the robot back to close to its starting position ready to pick up the ball just on the opposition side of the field.
Otherwise looks gtg to me.

Comment on lines +335 to +336
start_direction=Rotation2d.fromDegrees(-45),
end=Pose2d(0.4, -2.5, Rotation2d.fromDegrees(30)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
start_direction=Rotation2d.fromDegrees(-45),
end=Pose2d(0.4, -2.5, Rotation2d.fromDegrees(30)),
start_direction=Rotation2d.fromDegrees(0),
end=Pose2d(0.4, -2.5, Rotation2d.fromDegrees(0)),

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faster and more direct

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it go down to avoid any collisions with another robot that starts in our tarmac

Copy link
Member Author

@OliverW10 OliverW10 Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it also only adds 156ms to the path

@OliverW10 OliverW10 merged commit e09d4ef into main Mar 29, 2022
@OliverW10 OliverW10 deleted the auto-waypoint branch March 29, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants