iNodeEM: emit batt as int 100 instead of string "100"#690
Merged
DigiH merged 1 commit intodevelopmentfrom Apr 26, 2026
Merged
Conversation
The `_batt` static-value override was written as `["static_value", "100"]` (quoted), so when the byte-20 condition matches, the property is set to a string `"100"` instead of an int. Other rules' `static_value` numeric literals (e.g. battery percent fallbacks elsewhere) use unquoted numbers, so unwrapping it here aligns with the rest of the decoder and matches what the existing test_ble.cpp `expected` array already declares (`"batt":100`). Behaviour change is type-only — value is still 100 — but consumers that parse the JSON strictly (e.g. Python json.loads on an MQTT payload) now see an int where the expected output already promised an int. The upstream test passed before only because ArduinoJson 6's JsonVariant `!=` operator silently coerces a numeric string to a number. Strict consumers (Theengs Android app surfacing this via MQTT) saw the string and reported a field-type diff vs the catalog.
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The
_battstatic-value override was written as["static_value", "100"](quoted), so when the byte-20 condition matches, the property is set to a string"100"instead of an int. Other rules'static_valuenumeric literals (e.g. battery percent fallbacks elsewhere) use unquoted numbers, so unwrapping it here aligns with the rest of the decoder and matches what the existing test_ble.cppexpectedarray already declares ("batt":100).Behaviour change is type-only — value is still 100 — but consumers that parse the JSON strictly (e.g. Python json.loads on an MQTT payload) now see an int where the expected output already promised an int. The upstream test passed before only because ArduinoJson 6's JsonVariant
!=operator silently coerces a numeric string to a number. Strict consumers (Theengs Android app surfacing this via MQTT) saw the string and reported a field-type diff vs the catalog.Checklist: