add service_port argument#11
Merged
mbabineau merged 1 commit intothefactory:masterfrom Oct 9, 2014
danielfrg:master
Merged
Conversation
Member
|
(new in 0.7.3) |
mbabineau
added a commit
that referenced
this pull request
Oct 9, 2014
add service_port argument (Marathon 0.7.3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug when you tried to use the lib to start a docker container in marathon. The problem was that marathon is returning a json field
servicePortand the code is trying to map it toservice_portwhich didn't exists on the__init__.The problem only affected the response parsing, the task in marathon was created fine.
Now I was able to do it like this:
Thanks for the lib :)