Adds MarathonApp.add_env() method#166
Merged
solarkennedy merged 1 commit intothefactory:masterfrom Jan 26, 2017
daltonmatos:feature/add-env-method-on-marathon-app-model
Merged
Adds MarathonApp.add_env() method#166solarkennedy merged 1 commit intothefactory:masterfrom daltonmatos:feature/add-env-method-on-marathon-app-model
solarkennedy merged 1 commit intothefactory:masterfrom
daltonmatos:feature/add-env-method-on-marathon-app-model
Conversation
Contributor
|
Can you address the linting errors? ( |
Contributor
Author
|
Sure @solarkennedy ! It's done now. Sorry for not reading the project contributing instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds a convenient method to manipulate the dict of env vars of an App model. Hope it helps.
I'm currently building an HTTP API that sits in front of Marathon and I'm currently using your project to wrap all calls to Marathon HTTP API.