Updated event.py to handle app_terminated_event.#171
Merged
solarkennedy merged 2 commits intothefactory:masterfrom Feb 23, 2017
Merged
Updated event.py to handle app_terminated_event.#171solarkennedy merged 2 commits intothefactory:masterfrom
solarkennedy merged 2 commits intothefactory:masterfrom
Conversation
As of now, when the event stream gets a app_terminated_event, it raises an exeption :
MarathonError: Unknown event_type: app_terminated_event, data: {u'eventType': u'app_terminated_event', u'timestamp': u'2017-02-23T08:54:44.470Z', u'appId': u'/longtest/ms/beds-node'}
This fixs it.
I fixed the indentation that blocked the tests from passing, had only one carryage return instead of 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of now, when the event stream gets a app_terminated_event, it raises an exeption :
MarathonError: Unknown event_type: app_terminated_event, data: {u'eventType': u'app_terminated_event', u'timestamp': u'2017-02-23T08:54:44.470Z', u'appId': u'/longtest/ms/beds-node'}
This fixs it.
Closes #151.