handle case when non-ascii char are logged#188
Merged
solarkennedy merged 1 commit intothefactory:masterfrom Apr 12, 2017
tgermain:dev/tg/ascii
Merged
handle case when non-ascii char are logged#188solarkennedy merged 1 commit intothefactory:masterfrom tgermain:dev/tg/ascii
solarkennedy merged 1 commit intothefactory:masterfrom
tgermain:dev/tg/ascii
Conversation
Contributor
|
How about in init.py? |
Author
|
It's not the log itself but the
I tried to change the default formatter, the issue remain. |
Contributor
|
Oh, I understand now (I think). No I think this patch is ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #187 by encoding response in utf-8 before logging it.
It could also be done for the whole logger but I have no idea how right now.