Add raw_data option for event_stream method#189
Merged
solarkennedy merged 2 commits intothefactory:masterfrom Apr 19, 2017
Merged
Add raw_data option for event_stream method#189solarkennedy merged 2 commits intothefactory:masterfrom
solarkennedy merged 2 commits intothefactory:masterfrom
Conversation
Contributor
|
How but just |
fengyehong
force-pushed
the
raw-event-stream
branch
from
651460c to
dad3eb5
Compare
fengyehong
force-pushed
the
raw-event-stream
branch
from
dad3eb5 to
c748e84
Compare
Contributor
Author
|
updated and rebased |
Contributor
|
Why is travis not testing this?... |
When handling events asynchronously, you may just want to put event data in a message queue, so getting raw data here is a small optimization that saves parsing and serializing event data.
fengyehong
force-pushed
the
raw-event-stream
branch
from
c748e84 to
8fbd7a0
Compare
Contributor
Author
No idea |
Contributor
|
I've asked travisci and @mbabineau to turn it off and on again. In the mean time can you run the tests locally via tox and confirm that they pass? |
Contributor
Author
|
In fact, I have received Travis build success email for my forked repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a proposal. If you just store events in a message queue and leave it to other consumers, then there is no need to parse the event data as MarathonEvent object