Make travis automatically upload to pypi on new tags#223
Merged
solarkennedy merged 1 commit intomasterfrom Oct 16, 2017
Merged
Conversation
nhandler
approved these changes
Oct 16, 2017
Contributor
nhandler
left a comment
nhandler
left a comment
There was a problem hiding this comment.
Ship It! But see my comment for a change we will likely want to make to improve this.
| secure: "Wl8GWxsfPy4KoORYH26N3FllvMeWrifzeCbEx2Af4corcBQl43heeiFRRTlUOcSX0TIasER21PUvQ0R0cAgCjfknDb3SOROcRtcSBe16+cMmvwysfxcAx2OcF1UYBPY8e/qOsGge2Zyzx2PAPNEmJoWKbIT3vUJ4WvlLVeGYdJ0=" | ||
| on: | ||
| tags: true | ||
| condition: MARATHONVERSION == "1.4.7" |
Contributor
There was a problem hiding this comment.
I understand why you included this line, but I really don't like it. We will definitely forget to bump this version number as we change the marathon versions we test against. It also will upload to pypi even if tests are failing on older versions of Marathon (although in practice, those PRs should not be merged in the first place).
The better solution will likely be https://docs.travis-ci.com/user/build-stages , but they are still under Beta (and I'm not sure how well they work in practice).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.