Added region and zone members to task model.#260
Merged
solarkennedy merged 1 commit intothefactory:masterfrom Jan 2, 2019
Merged
Added region and zone members to task model.#260solarkennedy merged 1 commit intothefactory:masterfrom
solarkennedy merged 1 commit intothefactory:masterfrom
Conversation
Missing region and zone members resulted in stack trace when making calls to get_app under DCOS EE 1.11+
Contributor
Author
|
@solarkennedy Would it be possible to cut a 0.10.x release now that this change is merged? I'd like to reference the updates in a |
Contributor
|
@gisjedi released. |
Contributor
Author
|
Hugely appreciate the quick turn around! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing region and zone members resulted in stack trace when making calls
to
client.get_appunder DCOS EE 1.11+. I've resolved the problem with addition of both kwargs toMarathonTask. It was unclear to me how I could adequately test this with the behave tests. The main problem I had was in identifying how to enable the Marathon region and zone values in the open-source releases. I'm happy to provide test coverage if you can provide a pointer to how I'd accomplish this. Regardless, I've tested to ensure this resolves my individual problem.Stack trace snippet experienced when using
marathonpackage against DCOS EE 1.11.8 cluster deployed in AWS:This is the response from the /v2/apps/scale-elasticsearch/ Marathon API for reference: