Always create TZ-aware datetime objects. (also drop support for python 2)#267
Merged
solarkennedy merged 3 commits intothefactory:masterfrom Nov 14, 2019
Merged
Always create TZ-aware datetime objects. (also drop support for python 2)#267solarkennedy merged 3 commits intothefactory:masterfrom
solarkennedy merged 3 commits intothefactory:masterfrom
Conversation
Contributor
Author
|
Seems like the integration tests already broken in master with |
Contributor
|
Yea, I fought the itests for a while and gave up :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm tired of dealing with bugs in Paasta where the "naive" datetime objects returned by marathon-python inevitably are assumed to be in a different timezone than they really are.
We know exactly what timezone Marathon is emitting (it's always UTC); let's not have marathon-python act like we don't know that.
I recommend reading this branch one commit as a time. The goal of the PR is the last two commits, but in the first commit I drop support for py2 because the
datetimelibrary interface is different between py2 and py3 (notably, py2 does not havedatetime.timezone), and because py2 goes out of support in 6 weeks.