Updates for Marathon 1.9.109

[missingcharacter]

No description provided.

[dPeS]

+1 here, 0.12 don't work with 1.9.136
:
File "/home/pepto/.virtualenvs/scaler/lib/python3.6/site-packages/marathon/client.py", line 222, in list_apps response, MarathonApp, is_list=True, resource_name='apps') File "/home/pepto/.virtualenvs/scaler/lib/python3.6/site-packages/marathon/client.py", line 72, in _parse_response return [clazz.from_json(resource) for resource in target] File "/home/pepto/.virtualenvs/scaler/lib/python3.6/site-packages/marathon/client.py", line 72, in <listcomp> return [clazz.from_json(resource) for resource in target] File "/home/pepto/.virtualenvs/scaler/lib/python3.6/site-packages/marathon/models/base.py", line 43, in from_json return cls(**{to_snake_case(k): v for k, v in attributes.items()}) TypeError: __init__() got an unexpected keyword argument 'role'

[missingcharacter]

@dPeS do you get the role error when using my changes or do you encounter any other errors?

I'd like to improve my code if I can.

[solarkennedy]

Is apps expected to be a string you can validate on like this?

[missingcharacter]

I believe so, I tried different iterations and this was the one that worked for me. I admit I'm no python expert.

[solarkennedy]

Can you update the readme and maybe the test matrix?
I don't actually expect the build to go green, but maybe?

[missingcharacter]

@solarkennedy is this what you asked for?

[solarkennedy]

Cool. Can you check the failing tests next? They look real.

[missingcharacter]

@solarkennedy do you happen to have or now of a docker image that has all of these versions of mesos and marathon already baked in?

I'm trying to build the 14.04 image and keeps failing on ppa:webupd8team/java which seems to be discontinued

[solarkennedy]

I'm not aware of such an image.

I would accept a PR to use a standard image:
https://hub.docker.com/r/mesosphere/marathon
Maybe running in "development mode"?

Even if that means we have to only test against 1 version.

I don't know if there is a replacement for that PPA, or maybe the docker image itself could be upgraded to 20.04?

[missingcharacter]

@solarkennedy I'll try https://hub.docker.com/r/mesosphere/marathon and Ubuntu 20.04, I'll get back to you

[missingcharacter]

@solarkennedy I fixed the issues with the tests, whenever I have time I'll make another PR to fix the tests and use https://hub.docker.com/r/mesosphere/marathon