Moving marathon away from ubuntu and starting from mesosphere dockerhub#272
Merged
solarkennedy merged 5 commits intothefactory:masterfrom May 22, 2020
Merged
Conversation
| @@ -1,12 +1,29 @@ | |||
| #!/bin/bash | |||
Contributor
There was a problem hiding this comment.
I would be happy if you got rid of this script entirely.
Contributor
|
I would be just as happy if you only tested against 1 version (latest) of marathon and didn't try to do the whole matrix thing with the args and junk. I don't think it is worth it now. |
Contributor
Author
|
@solarkennedy fwiw they all seem to work now https://travis-ci.org/github/missingcharacter/marathon-python/builds/689865380 |
Contributor
|
Woot! Thanks! This is above and beyond! |
Contributor
|
@mbabineau can you make @missingcharacter a contributor? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes work locally, I've not tested TravisCI yet.
If you are ok with using pre-built container images, I'd change the tests to build everytime and just pull the images from https://hub.docker.com/r/missingcharacter/marathon-python/tags
It might be a good idea for you guys to create your own repository in hub.docker.com for the images to be pulled from.