Fix deserialization for Deploment model#275
Closed
gabber12 wants to merge 3 commits intothefactory:masterfrom
Closed
Fix deserialization for Deploment model#275gabber12 wants to merge 3 commits intothefactory:masterfrom
gabber12 wants to merge 3 commits intothefactory:masterfrom
Conversation
Contributor
|
I don't know why this is "new", but on py36 tests can you fix: |
Contributor
|
@solarkennedy would this be enough? from marathon.models.deployment import MarathonDeployment
import unittest
class MarathonDeploymentTest(unittest.TestCase):
def test_env_defaults_to_empty_dict(self):
"""
é testé
"""
deployment_json = {
"id": "ID",
"version": "2020-05-30T07:35:04.695Z",
"affectedApps": ["/app"],
"affectedPods": [],
"steps": [{
"actions": [{
"action": "RestartApplication",
"app": "/app"
}]
}],
"currentActions": [{
"action": "RestartApplication",
"app": "/app",
"readinessCheckResults": []
}],
"currentStep": 1,
"totalSteps": 1
}
deployment = MarathonDeployment.from_json(deployment_json)
self.assertEquals(deployment.id, "ID")
self.assertEquals(deployment.current_actions[0].app, "/app") |
Contributor
|
I can't quite tell, but just do what flake8 wants to make the build green? |
Contributor
|
I'm closing this one in favor of #276 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.