Raise exceptions instead of swallowing them silently#3
Merged
mbabineau merged 1 commit intothefactory:masterfrom Aug 4, 2014
StephanErb:master
Merged
Raise exceptions instead of swallowing them silently#3mbabineau merged 1 commit intothefactory:masterfrom StephanErb:master
mbabineau merged 1 commit intothefactory:masterfrom
StephanErb:master
Conversation
StephanErb
changed the title
Member
|
Agreed, we should let these exceptions bubble up. Thanks for the patch! |
mbabineau
added a commit
that referenced
this pull request
Aug 4, 2014
Raise exceptions instead of swallowing them silently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
when exceptions are catched and printed in marathon-python, I loose the ability to handle them in upper layers where I have more context to react properly. This pull requests is meant to change that.
Best Regards,
Stephan