Removed previously unused test framework in favor of tox + docker-compose version#49
Merged
solarkennedy merged 1 commit intomasterfrom Jul 15, 2015
Merged
Conversation
Contributor
|
@solarkennedy I agree, the integration tests were too complicated to setup and run. I added them because I didn't want to create a PR without having some tests to run and none had previously existed. I can submit a new suite of tests in a separate PR that are easier to run. |
Contributor
Author
|
Don't get me wrong, I really appreciate the testing! |
solarkennedy
added a commit
that referenced
this pull request
Jul 15, 2015
Removed previously unused test framework in favor of tox + docker-compose version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kevinschoon this is me trying to finish the transition from these manual tests to the new ones.
The new tests run via travis, or locally. I think it is going to be easier for someone to run the new tests locally because it only requires having docker installed. The previous test suite required that the user already have marathon and a mesos setup with docker enabled, and a callback server available on 192.0.2.1. And of course if they don't want to run the tests, Travis will for them.
Having these tests is good, but nobody ran them as evidence of the broken appid validation logic that got into master.
I don't want an unused test suite around that nobody is running, it will rot, so I'm deleting it in this PR.
If you want test coverage on the HTTP callback functionality of marathon+marthon-python, please PR a new version of these tests that can be run in the new itest suite, and automatically via Travis. This will ensure it will stay up-to-date as things change.