Add support for /v2/events stream#91
Conversation
|
Hmm. This is kinda new and different. Can you add an itest for it? |
|
Thank you. Long term, if you need this feature to continue to work as marathon evolves, it needs to have a section in the actual itest code that actually tries to read the events and maybe asserts that there is like, something? But this technically isn't a blocker to merging. My last request is that you rebase, I merged in a bunch of pep8 fixes. |
|
Hi, |
|
Ok, the last thing to do is to bring it up to pep8 compliance. Check out the flake8 issues in an example travis run: https://travis-ci.org/thefactory/marathon-python/jobs/123588467 Or run tox -e pep8 |
|
Tests are failing on marathon waiting timeout. |
|
It looks like the feature isn't really supported till 0.11.0 due to d2iq-archive/marathon#1926 |
|
This looks great to me. Thank you very much for iterating through the tests and pep8 and all the things. Thanks! |
The PR allows to use event stream from Marathon REST API added in v0.9.0