feat(search): widen silent-empty alert to emergent/condition queries (#88 follow-up)#89
Merged
Merged
Conversation
Council #88 follow-up: isClinical was dosing-keyword-only, so bare emergent queries (chest pain, stroke, cardiac arrest) that blank-screen for a resolved agency did NOT alert. New pure isClinicalQuery() reuses the normalizer's intent / isEmergent / extractedConditions / extractedMedications signals. +5 unit tests (10/10 pass).
✅ Deploy Preview for protocol-guide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to PR #88 — closes the Council's #1 clinical-safety nit.
isClinicalwas dosing-keyword-only, so bare emergent/condition queries ("chest pain", "stroke", "cardiac arrest", "anaphylaxis") that return ZERO results for a resolved agency did not alert — the exact blank-screen-mid-call case.Change
isClinicalQuery()indegradation-alert.ts— reuses the normalizer'sintent/isEmergent/extractedConditions/extractedMedications+ a dosing-keyword fallback.semantic.tsempty-result alert now uses it.Safety
Additive observability only — widens when we alert; no results behavior change. Cannot regress retrieval.