Fixes #27005 - Fix Editor changing locked template#6840
Merged
ohadlevy merged 1 commit intotheforeman:developfrom Jun 13, 2019
Merged
Fixes #27005 - Fix Editor changing locked template#6840ohadlevy merged 1 commit intotheforeman:developfrom
ohadlevy merged 1 commit intotheforeman:developfrom
Conversation
Member
|
Issues: #27005 |
ezr-ondrej
reviewed
Jun 11, 2019
Member
ezr-ondrej
left a comment
ezr-ondrej
left a comment
There was a problem hiding this comment.
👍 Thanks @glekner, fixes the issue and LGTM.
Only one nitpick.
Member
There was a problem hiding this comment.
isn't the readOnly prop useless now as it is always false?
Contributor
Author
There was a problem hiding this comment.
its a textarea without onChange handler. due to the Editor taking care of the onChange, it needs to be readOnly aswell.
Member
There was a problem hiding this comment.
ack! thanks for explanation! ❤️
Member
There was a problem hiding this comment.
does this warrant adding a test?
ezr-ondrej
previously approved these changes
Jun 11, 2019
Member
|
The errors are unrelated, but maybe would be better to wait for them to be resolved anyway. The fix is in #6833 |
glekner
force-pushed
the
fix-editor-readonly
branch
from
ac285e9 to
fce9fbc
Compare
ohadlevy
previously approved these changes
Jun 13, 2019
glekner
force-pushed
the
fix-editor-readonly
branch
from
fce9fbc to
161f6c5
Compare
ohadlevy
approved these changes
Jun 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.