fixes #32179 - Return code 404 instead of 500 missing subnet#103
Merged
lzap merged 1 commit intotheforeman:masterfrom Mar 29, 2021
domitea:32179_fix
Merged
fixes #32179 - Return code 404 instead of 500 missing subnet#103lzap merged 1 commit intotheforeman:masterfrom domitea:32179_fix
lzap merged 1 commit intotheforeman:masterfrom
domitea:32179_fix
Conversation
lzap
reviewed
Mar 29, 2021
| end | ||
|
|
||
| def subnet_not_found | ||
| not_found ("Subnet not found by id '%s'") % params[:id] |
Member
There was a problem hiding this comment.
Subnet with id %s not found
sounds probably little bit better. Tests fail tho.
Member
There was a problem hiding this comment.
I'd still prefer a cleaner message, but whatever.
Member
|
There are (irrelevant) rubocop failures, can you fix them please? |
lzap
reviewed
Mar 29, 2021
| end | ||
| end | ||
| end | ||
|
|
Member
There was a problem hiding this comment.
These three files do not seem to be related, was this added by mistake?
Contributor
Author
There was a problem hiding this comment.
Yes, the mistake - that's happen when you're working on the bootdisk improvements at many fronts :/
Bootdisk should return code 404 for missing subnet
lzap
approved these changes
Mar 29, 2021
| end | ||
|
|
||
| def subnet_not_found | ||
| not_found ("Subnet not found by id '%s'") % params[:id] |
Member
There was a problem hiding this comment.
I'd still prefer a cleaner message, but whatever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bootdisk should return code 404 for missing subnet