Merged
Conversation
we don't need them right now and it's confusing to the user
arvind4501
approved these changes
Mar 24, 2026
shubhamsg199
approved these changes
Mar 24, 2026
Gauravtalreja1
approved these changes
Mar 24, 2026
Gauravtalreja1
left a comment
There was a problem hiding this comment.
ACK, Tested this by manually updating /usr/bin/foremanctl and it works correctly to disable extra vars
Before Fix
# foremanctl features -h
usage: foremanctl features [-h] [-v] [-e EXTRA_VARS] [--list-enabled]
List all enabled and available features
options:
-h, --help show this help message and exit
-v, --verbose verbose output
--list-enabled List only enabled features
advanced arguments:
-e EXTRA_VARS, --extra-vars EXTRA_VARS
set additional variables as key=value or YAML/JSON, if filename prepend with @
Parameters marked as (persisted) can be reset by --reset-<parameter-name>.
After Fix
# foremanctl features -h
usage: foremanctl features [-h] [-v] [--list-enabled]
List all enabled and available features
options:
-h, --help show this help message and exit
-v, --verbose verbose output
--list-enabled List only enabled features
Parameters marked as (persisted) can be reset by --reset-<parameter-name>.
I missed to post this comment before merge :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we don't need them right now and it's confusing to the user