Skip to content

disable extra vars#414

Merged
evgeni merged 1 commit intomasterfrom
disable-extra-vars
Mar 24, 2026
Merged

disable extra vars#414
evgeni merged 1 commit intomasterfrom
disable-extra-vars

Conversation

@evgeni
Copy link
Copy Markdown
Member

@evgeni evgeni commented Mar 24, 2026

we don't need them right now and it's confusing to the user

we don't need them right now and it's confusing to the user
Comment thread foremanctl
@evgeni evgeni merged commit cc79720 into master Mar 24, 2026
18 of 20 checks passed
@evgeni evgeni deleted the disable-extra-vars branch March 24, 2026 08:37
Copy link
Copy Markdown

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, Tested this by manually updating /usr/bin/foremanctl and it works correctly to disable extra vars

Before Fix

# foremanctl features -h
usage: foremanctl features [-h] [-v] [-e EXTRA_VARS] [--list-enabled]

List all enabled and available features

options:
  -h, --help            show this help message and exit
  -v, --verbose         verbose output
  --list-enabled        List only enabled features

advanced arguments:
  -e EXTRA_VARS, --extra-vars EXTRA_VARS
                        set additional variables as key=value or YAML/JSON, if filename prepend with @

Parameters marked as (persisted) can be reset by --reset-<parameter-name>.

After Fix

# foremanctl features -h
usage: foremanctl features [-h] [-v] [--list-enabled]

List all enabled and available features

options:
  -h, --help      show this help message and exit
  -v, --verbose   verbose output
  --list-enabled  List only enabled features

Parameters marked as (persisted) can be reset by --reset-<parameter-name>.

I missed to post this comment before merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants