Generate passwords instead of using hard-coded ones#524
Open
evgeni wants to merge 1 commit into
Open
Conversation
ekohl
reviewed
May 27, 2026
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Neat. Should we document this pattern in developer docs?
Member
Author
I guess that'd be a good idea |
ehelms
reviewed
May 27, 2026
ehelms
reviewed
May 27, 2026
|
|
||
| ```yaml | ||
| example_database_password_file: "{{ obsah_state_path }}/example-db-password" | ||
| example_database_password: "{{ lookup('ansible.builtin.password', example_database_password_file, chars=['ascii_letters', 'digits']) }}" |
Member
There was a problem hiding this comment.
Is it possible to turn this into a single filter that enforces this pattern? Or have an Ansible lint rule that enforces it?
Member
Author
There was a problem hiding this comment.
You mean a lookup(foremanctl_password) that does the right settings for us? Not sure.
But I'll investigate both options
Member
Author
There was a problem hiding this comment.
Okay, a lint rule was reasonably easy, added in #526
Open
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
Generate passwords instead of using hard-coded ones
What are the changes introduced in this pull request?
Generate passwords instead of using hard-coded ones
How to test this pull request
Steps to reproduce:
CHANGMEpasswords/keys are usedChecklist