Skip to content

Always use the certs from the quadlet machine in the tests #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evgeni wants to merge 4 commits into
base: master
Choose a base branch
from
+32 −7
Open

Always use the certs from the quadlet machine in the tests #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
671e2d9
refactor paramiko host fetcher
evgeni Jul 24, 2026
2c68f76
use the quadlet cert in curl_request
evgeni Jul 24, 2026
21421f4
add bmc feature to the proxy
evgeni Jul 24, 2026
aaa39bd
try overriding the fixture
evgeni Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,8 @@ jobs:
--auth-bundle $(pwd)/.var/lib/foremanctl/proxy.example.com.tar.gz \
--foreman-fqdn quadlet.example.com \
--templates-listen-on http \
--templates-url http://proxy.example.com:8000
--templates-url http://proxy.example.com:8000 \
--add-feature bmc
- name: Run tests
run: |
./forge test --pytest-args="--server-hostname=proxy"
Expand Down
36 changes: 30 additions & 6 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,25 +130,45 @@ def default_certificates(certificate_source):
pytest.skip("Only applies to non-custom certificate deployments")


@pytest.fixture(scope="module")
def quadlet_client_certificate():
# this intentionally uses get_paramiko_host directly, as we want the cert of the quadlet box
# not the one "server" points at, as that can be the proxy
quadlet = get_paramiko_host('quadlet')
hostname = quadlet.run("hostname -f").stdout.strip()
cert = quadlet.file(f"/var/lib/foremanctl/certs/certs/{hostname}-client.crt").content_string
key = quadlet.file(f"/var/lib/foremanctl/certs/private/{hostname}-client.key").content_string
return (cert, key)


@pytest.fixture(scope="module")
def client_certificate():
return quadlet_client_certificate


@pytest.fixture(scope="module")
def database_mode(obsah_params):
return obsah_params.get('database_mode', 'internal')


def get_paramiko_host(hostname):
return testinfra.get_host(f'paramiko://{hostname}', sudo=True, ssh_config=SSH_CONFIG)


@pytest.fixture(scope="module")
def server(server_hostname):
yield testinfra.get_host(f'paramiko://{server_hostname}', sudo=True, ssh_config=SSH_CONFIG)
yield get_paramiko_host(server_hostname)


@pytest.fixture(scope="module")
def client(client_hostname):
yield testinfra.get_host(f'paramiko://{client_hostname}', sudo=True, ssh_config=SSH_CONFIG)
yield get_paramiko_host(client_hostname)


@pytest.fixture(scope="module")
def database(database_mode, server):
if database_mode == 'external':
yield testinfra.get_host('paramiko://database', sudo=True, ssh_config=SSH_CONFIG)
yield get_paramiko_host('database')
else:
yield server

Expand Down Expand Up @@ -340,13 +360,17 @@ def proxy_base_url(server_fqdn):


@pytest.fixture(scope="module")
def curl_request(server, certificates, server_fqdn):
def curl_request(server, server_fqdn, certificates, client_certificate):
cert, key = client_certificate
server.run(f"echo '{cert}' > /tmp/quadlet.crt")
server.run(f"echo '{key}' > /tmp/quadlet.key")

def _request(path, base_url=None, method=None, data=None, headers=None, return_body=False):
url = f"{base_url or f'https://{server_fqdn}'}/{path}"
curl_opts = (
f"--cacert {certificates['server_ca_certificate']} "
f"--cert {certificates['client_certificate']} "
f"--key {certificates['client_key']} "
f"--cert /tmp/quadlet.crt "
f"--key /tmp/quadlet.key "
f"--silent "
)
if not return_body:
Expand Down
Loading