Configuring Candlepin with environment variables#71
Configuring Candlepin with environment variables#71ehelms wants to merge 1 commit intotheforeman:masterfrom
Conversation
| candlepin_container_image: quay.io/ehelms/candlepin | ||
| candlepin_container_tag: 4.4.14 | ||
|
|
||
| candlepin_db_user: candlepin |
There was a problem hiding this comment.
This looks like you were experimenting with something else and ended up committing it too.
There was a problem hiding this comment.
Correct - I started doing all of them and then decided to just do one to see what it looked and felt like.
|
|
||
| candlepin.auth.oauth.enable=true | ||
| candlepin.auth.oauth.consumer.katello.secret={{ candlepin_oauth_secret }} | ||
| candlepin.auth.oauth.consumer.katello.secret="NOTTHEREALSECERT" |
There was a problem hiding this comment.
Do we even need to include this in the config file if we're not passing it? Right now I can see a failure mode where it somehow isn't provided/respected and the password ends up being NOTTHEREALSECERT. If you don't provide at all I'd hope that Candlepin has a sane default that refuses to work.
There was a problem hiding this comment.
I have it here to test whether the environment variables overwrite what's in the config. To see if that provides a way to ship defaults but know that we can provide a configuration option to users if need be by adding the environment variable.
If we went this route as a whole, the question would be do we include this in the .conf file available in the container. I could see for anything that is a "secret" we opt not to include it. For other elements, we include a sane default that can be overridden.
|
The programmatic configuration options detailed below do not appear to be able to be set via environment variables in the combinations I have tried. This would mean we'd still end up with having to deploy a config file. |
I took one configuration option for
candlepin.confto see what it would look like to have an option we configure to be deployed as an environment variable.