Use version to disable pulling from upstream during an update#144
Merged
ehelms merged 1 commit intotheforeman:masterfrom Oct 18, 2018
Merged
Use version to disable pulling from upstream during an update#144ehelms merged 1 commit intotheforeman:masterfrom
ehelms merged 1 commit intotheforeman:masterfrom
Conversation
d372f0a to
e18ff35
Compare
Member
|
The tests fail because the packaging repo stubs we ship are no git repositories. There is some code that does a git setup, but it's not used universally: Lines 74 to 84 in cabab36 Other than that, I think |
Member
|
#145 should fix the tests for you. |
Member
|
Given no tests broke when you modified this behavior in #68, I think we should add tests for this branch of logic now? |
e18ff35 to
8ff5c23
Compare
evgeni
reviewed
Oct 18, 2018
tests/test_functional.py
Outdated
|
|
||
| assert not os.path.exists('packages/hello/hello-2.9.tar.gz') | ||
| assert not os.path.islink('packages/hello/hello-2.9.tar.gz') | ||
| assert os.path.islink('packages/hello/hello-2.10.tar.gz') |
Member
There was a problem hiding this comment.
you can't fetch hello.tar from example.com (and thus git-annex blows up), so maybe let's just skip this assert
8ff5c23 to
39d5f34
Compare
39d5f34 to
d428156
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.