Skip to content

Ignore URLs in commit message line lengths#43

Merged
ehelms merged 1 commit intotheforeman:masterfrom
domcleal:ignore-url-length
Jun 2, 2016
Merged

Ignore URLs in commit message line lengths#43
ehelms merged 1 commit intotheforeman:masterfrom
domcleal:ignore-url-length

Conversation

@domcleal
Copy link
Copy Markdown

@domcleal domcleal commented Jun 2, 2016

Prevents warning on a commit message such as:

Rails source where relative controller is assumed by url_for if no named
route was given (the :use_route option):
https://github.com/rails/rails/blob/v4.2.6/actionpack/lib/action_dispatch/routing/route_set.rb#L695-L698

I think this is quite reasonable and better than using a URL shortener as it's a permanent URL that avoids a dependency on both a shortener service and even GitHub - it's quite usable if you even had a copy of the Rails release or repo with the data in the URL.

(theforeman/foreman#3564 (comment))

@dLobatog
Copy link
Copy Markdown
Member

dLobatog commented Jun 2, 2016

LGTM - I've had this problem too and it doesn't make much sense. Can't merge though (no rights)

@ehelms
Copy link
Copy Markdown
Member

ehelms commented Jun 2, 2016

Thanks @domcleal !

@ehelms ehelms merged commit 4dfa52d into theforeman:master Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants