Ignore URLs in commit message line lengths#43
Merged
ehelms merged 1 commit intotheforeman:masterfrom Jun 2, 2016
Merged
Conversation
Member
|
LGTM - I've had this problem too and it doesn't make much sense. Can't merge though (no rights) |
Member
|
Thanks @domcleal ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents warning on a commit message such as:
I think this is quite reasonable and better than using a URL shortener as it's a permanent URL that avoids a dependency on both a shortener service and even GitHub - it's quite usable if you even had a copy of the Rails release or repo with the data in the URL.
(theforeman/foreman#3564 (comment))