Skip to content
This repository was archived by the owner on Sep 5, 2025. It is now read-only.

Release 6.3.0#76

Merged
ehelms merged 1 commit into
theforeman:masterfrom
wbclark:release-6.3.0
Apr 26, 2021
Merged

Release 6.3.0#76
ehelms merged 1 commit into
theforeman:masterfrom
wbclark:release-6.3.0

Conversation

@wbclark

@wbclark wbclark commented Apr 21, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@ekohl ekohl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed you didn't apply the skip-changelog label which the script should do:
theforeman/foreman-installer-modulesync@8e6476a#diff-757da4b86492c64be1b8e5ea7c5cfbae717e2a555ab0746979b6164e5c6cb6a5

Can you please make sure you do so? It saves manual work later on.

Comment thread CHANGELOG.md
@wbclark

wbclark commented Apr 21, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for catching that @ekohl . The script unfortunately doesn't always work for me and I don't think it works for @ehelms either. I usually add the label manually when opening the PR and missed it in this case.

I do understand the extra work it causes because the label was also missed on a prior release of another module, so I had to apply the label to the previous PR and regenerate changelogs.

I think the solution to this problem is to go over the release scripts and ensure they are portable across environments. I'll create a backlog item to do that.

@ehelms

ehelms commented Apr 23, 2021

Copy link
Copy Markdown
Member

Where did we land here on which way we are approaching Puppet 7 support changes?

@ekohl

ekohl commented Apr 23, 2021

Copy link
Copy Markdown
Member

I thought more about it. In an ideal world, widening support in metadata.json is a very safe thing. However, not all dependency resolution is that smart. Because of that, I agree that it is an enhancement that warrants a minor version bump.

@wbclark

wbclark commented Apr 26, 2021

Copy link
Copy Markdown
Contributor Author

Updated release date for Monday April 26th

@ehelms ehelms merged commit 6770a64 into theforeman:master Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants