Add apache config support for /pypi

[pavanshekar]

Summary

Add Apache config support for /pypi in puppet-pulpcore

Fixes: SAT-44474

Changes

• Added use_pypi_route parameter to pulpcore::plugin::python (default: true)
• Generates Apache <Location "/pypi"> block that proxies to pulpcore-api service
• Added comprehensive tests for the new parameter

Generated Apache Config

When use_pypi_route => true (default), the module should generate:

  <Location "/pypi">                                                                                                                           
    RequestHeader unset X-CLIENT-CERT                                                                                                          
    RequestHeader set X-CLIENT-CERT "%{SSL_CLIENT_CERT}s" env=SSL_CLIENT_CERT                                                                  
    RequestHeader set X-FORWARDED-PROTO expr=%{REQUEST_SCHEME}                                                                                 
    ProxyPass unix:///run/pulpcore-api.sock|http://pulpcore-api/pypi timeout=600
    ProxyPassReverse unix:///run/pulpcore-api.sock|http://pulpcore-api/pypi                                                                    
  </Location>

[qcjames53]

I was (finally) able to get this to run as a part of foreman-installer on a clean dev environment. After pulling changes and re-running installer, the Apache config successfully includes the new endpoint:

[vagrant@centos9-pulp-upgrade ~]$ sudo cat /etc/httpd/conf.d/05-foreman-ssl.conf
...
  <Location "/pypi">
    RequestHeader unset X-CLIENT-CERT
    RequestHeader set X-CLIENT-CERT "%{SSL_CLIENT_CERT}s" env=SSL_CLIENT_CERT
    RequestHeader set X-FORWARDED-PROTO expr=%{REQUEST_SCHEME}
    ProxyPass unix:///run/pulpcore-api.sock|http://pulpcore-api/pypi timeout=600
    ProxyPassReverse unix:///run/pulpcore-api.sock|http://pulpcore-api/pypi
  </Location>

The unit test passes and looks fit for purpose. The source seems good to me as well. Approving changes. @ekohl how are things looking to you?

[ekohl]

Looks good. I've kicked off CI to see if it agrees.

[pavanshekar]

CI is failing. What should I do to resolve this?

[qcjames53]

The failure in test setup looks unrelated to me.

[ekohl]

I think this is due to voxpupuli/gha-puppet@fd171ad.