Feature: #947 add facter.conf management of blocklist, cache#950
Open
ikonia wants to merge 25 commits intotheforeman:masterfrom
Open
Feature: #947 add facter.conf management of blocklist, cache#950ikonia wants to merge 25 commits intotheforeman:masterfrom
ikonia wants to merge 25 commits intotheforeman:masterfrom
Conversation
bastelfreak
reviewed
Sep 2, 2025
bastelfreak
reviewed
Sep 2, 2025
manifests/agent/facter.pp
Outdated
|
|
||
|
|
||
| if $::blocklist { | ||
| hocon_setting { 'blocklist facts group': |
Member
There was a problem hiding this comment.
can't we also write json to the facter conf? Then we don't need a dependency to the hocon module.
Author
There was a problem hiding this comment.
functionality completed - now moving out of hocon
Member
There was a problem hiding this comment.
I am not 100% sure if JSON works, but it's worth a try.
Author
There was a problem hiding this comment.
the first few tests sort of worked, but added complexity, more work required before discounting
bastelfreak
reviewed
Sep 2, 2025
ekohl
reviewed
Feb 5, 2026
| Optional[Array[String]] $cachelist = undef, | ||
| String $cache_ttl = '1 day', | ||
| ) { | ||
| file { '/etc/puppetlabs/facter': |
Member
There was a problem hiding this comment.
Please introduce the base directory as a parameter to allow for non-AIO builds.
|
|
||
| hocon_setting { 'facter.conf': | ||
| path => '/etc/puppetlabs/facter/facter.conf', | ||
| require => File['/etc/puppetlabs/facter'], |
Member
There was a problem hiding this comment.
I'd wish hocon_setting would autorequire this, but didn't check if it really did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds the ability to manage facter blocklist and cache list for puppet agent by.
%99.99 of this work is credited to @vchepkov Vadym Chepkov