Skip to content

Replace pika with microbundle#100

Merged
cowboyd merged 2 commits intomasterfrom
microbundle
Apr 23, 2020
Merged

Replace pika with microbundle#100
cowboyd merged 2 commits intomasterfrom
microbundle

Conversation

@jnicklas
Copy link
Copy Markdown
Collaborator

Pika doesn't play well with the monorepo architecture that we have. Because it has its own package.json file in pkg, the main effection package is essentially unusable from other packages in the repo. With microbundle we don't have this problem.

@jnicklas jnicklas requested a review from cowboyd April 23, 2020 15:40
We had the capability to use a custom publish script other than `npm
publish` specifically because of `pika`
@github-actions
Copy link
Copy Markdown
Contributor

A preview package of this pull request has been published with the tag microbundle.
You can try it out by running the following command:

$ npm install effection@microbundle

or by updating your package.json to:

{
  "effection": "microbundle"
}

Generated by 🚫 dangerJS against 6b80aaa

@cowboyd
Copy link
Copy Markdown
Member

cowboyd commented Apr 23, 2020

I ran this against the bigtest test suite which was all green

@cowboyd cowboyd merged commit 85b5a48 into master Apr 23, 2020
@cowboyd cowboyd deleted the microbundle branch April 23, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants