Merged
Conversation
commit: |
Member
|
Appreciate the PR! Two quick asks, and we can get it merged a published.
|
rrthomas
added a commit
to ursalang/ursa
that referenced
this pull request
Jul 19, 2025
See thefrontside/effection#1007 for a fix for the latest v3.
This is related to PR thefrontside#935. Unfortunately, webpack follows even dynamic imports unless told not to. This one-line change adds the magic comment to tell webpack not to try to import ‘node:process’.
Author
|
Many thanks for the quick review. I have added a comment with a link to webpack documentation. I will test the preview package and report back. |
Author
|
Confirmed that the PR preview package fixes working with webpack for me. |
rrthomas
added a commit
to ursalang/ursa
that referenced
this pull request
Jul 19, 2025
jbolda
approved these changes
Jul 20, 2025
Member
jbolda
left a comment
jbolda
left a comment
There was a problem hiding this comment.
Perfect, thanks! Will get it published right quick too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to PR #935. Unfortunately, webpack follows even dynamic
imports unless told not to. This one-line change adds the magic comment to
tell webpack not to try to import ‘node:process’.
Motivation
This PR fixes webpack compatibility.
Approach
This PR adds a single comment to tell webpack not to try to import
node:process.