🐛main operation was failing without explicit exit.#722
Merged
Conversation
`main()` only works correctly whenever you call `yield* exit()` or if there was a error, because it relies on resolving a containing action (the entire main method is just one big action). However, if your operation completes successfully and you _don't_ invoke the exit operation, then it fails because the main action never resolves. This was because we were returning early from the action. This removes the return statement and places the implicit exit into a more prominent location so that we are always guaranteed to resolve ith an exit status no matter what.
cowboyd
force-pushed
the
cl/main-implicit-exit
branch
from
05f4ad0 to
ccd0e5e
Compare
neurosnap
approved these changes
Jul 7, 2023
taras
pushed a commit
that referenced
this pull request
Nov 12, 2025
🐛main operation was failing without explicit exit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
main()only works correctly whenever you callyield* exit()or if there was a error, because it relies on resolving a containing action (the entire main method is just one big action).However, if your operation completes successfully and you don't invoke the exit operation, then it fails because the main action never resolves. This was because we were returning early from the action.
Approach
This removes the return statement and places the implicit exit into a more prominent location so that we are always guaranteed to resolve ith an exit status no matter what.