Merged
Conversation
cowboyd
force-pushed
the
add-more-typedocs
branch
from
4d7280b to
b80b5d0
Compare
neurosnap
reviewed
Oct 8, 2023
cowboyd
force-pushed
the
add-more-typedocs
branch
from
b80b5d0 to
1c5b16f
Compare
cowboyd
force-pushed
the
add-more-typedocs
branch
from
1c5b16f to
eb463cf
Compare
taras
approved these changes
Oct 11, 2023
Now that interfaces are getting more defined, we should add typedocs for them. This also removes the `log.ts` APIs which were always very theoretical.
cowboyd
force-pushed
the
add-more-typedocs
branch
from
d8ae847 to
3f0bfe2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Now that interfaces are getting more defined, we should add typedocs for them, which is necessary for a public release
Approach
This also removes the
log.tsAPIs which were always very theoretical.